[semconv] update template to remove deprecated semconv attributes #10829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is updating the jinja template to ignore deprecated attributes as was done in open-telemetry/opentelemetry-go#5476. Additonally, generate v1.26.0 semconv package Signed-off-by: Alex Boten <[email protected]>
codeboten
commented
Aug 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10829 +/- ##
==========================================
+ Coverage 91.64% 91.65% +0.01%
==========================================
Files 406 406
Lines 18987 18987
==========================================
+ Hits 17400 17402 +2
+ Misses 1227 1226 -1
+ Partials 360 359 -1 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
Aug 7, 2024
dmitryax
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is updating the jinja template to ignore deprecated attributes as was done in open-telemetry/opentelemetry-go#5476. Additonally, generate v1.26.0 semconv package
This replaces #10249
Fixes #10813
NOTE: This leaves empty resource/trace/event files, but I'd rather not remove the methods they expose in this change